Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestNG does not fail if feature files are not parseable #953

Closed
sventorben opened this issue Jan 22, 2016 · 2 comments
Closed

TestNG does not fail if feature files are not parseable #953

sventorben opened this issue Jan 22, 2016 · 2 comments

Comments

@sventorben
Copy link
Contributor

If a feature file has an invalid syntax and is not parseable, the dataprovider in AbstractTestNGCucumberTests does not fail. The dataprovider does not provide any feature to the test method. Accordingly, no tests are executed and the no tests fails.

I would expect the test to fail!
@aslakhellesoy
Copy link
Contributor

Would you be interested in sending a pull request with a fix and a test?

sventorben added a commit to sventorben/cucumber-jvm that referenced this issue Jan 22, 2016
@sventorben
Allows to configure TestNG to fail on unparseable feature files
952fdca 
TestNG DataProvider did not fail if a feature file was not parseable.
This commit allows to configure whether a test fails if at least one
feature file is not parseable.
In addition, test always fails if at least one feature file is not
parseable and strict mode is enabled.

Fixes cucumber#953
@sventorben sventorben mentioned this issue Jan 22, 2016
Closed
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aslakhellesoy @sventorben