URLOutputStream Should Check for Directory Existance

[joshar1]

The maven surefire plugin offers the ability to run tests in parallel with the parallel parameter.

While attempting to execute my Cucumber tests in parallel, I noticed that the URLOutputStream class was throwing exceptions because the ensureParentDirExists method was not checking that the directory already existed prior to attempting to create the directory.

I propose the following one line change.

From:

if (file.getParentFile() != null && !file.getParentFile().isDirectory()) {

To:

if (file.getParentFile() != null && !file.getParentFile().isDirectory() 
     && !file.getParentFile().exists()) {

If this change is acceptable to others, I'll fork and issue a pull request.

[aslakhellesoy]

Can isDirectory() return true if the directory doesn't exist?

[klausbayrhammer]

I couldn't create a test with the behaviour you did describe. Could you provide a small code-sample?

[mpkorstanje]

Hey @joshar1 I'm cleaning up old tickets. Do you still experience this problem?

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.