Skip to content

Commit

Permalink
Changes as per PR comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
Prashant Ramcharan committed Apr 7, 2018
1 parent 80c4c7e commit 2e30f73
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion core/src/main/java/cucumber/runtime/Stats.java
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public List<Throwable> getErrors() {

public byte exitStatus(boolean isStrict) {
byte result = 0x0;
if (!failedScenarios.isEmpty() || (isStrict && (!pendingScenarios.isEmpty() || !undefinedScenarios.isEmpty() || !ambiguousScenarios.isEmpty()))) {
if (!failedScenarios.isEmpty() || !ambiguousScenarios.isEmpty() || (isStrict && (!pendingScenarios.isEmpty() || !undefinedScenarios.isEmpty()))) {
result |= ERRORS;
}
return result;
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/resources/cucumber/api/cli/USAGE.txt
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Options:
-n, --name REGEXP Only run scenarios whose names match REGEXP.
-d, --[no-]-dry-run Skip execution of glue code.
-m, --[no-]-monochrome Don't colour terminal output.
-s, --[no-]-strict Treat undefined, pending and ambiguous steps as errors.
-s, --[no-]-strict Treat undefined and pending steps as errors.
--snippets [underscore|camelcase] Naming convention for generated snippets.
Defaults to underscore.
-v, --version Print version.
Expand Down
2 changes: 1 addition & 1 deletion core/src/test/java/cucumber/runtime/RuntimeTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ public void non_strict_with_ambiguous_scenarios() {
Runtime runtime = createNonStrictRuntime();
runtime.getEventBus().send(testCaseFinishedWithStatus(Result.Type.AMBIGUOUS));

assertEquals(0x0, runtime.exitStatus());
assertEquals(0x1, runtime.exitStatus());
}

@Test
Expand Down

0 comments on commit 2e30f73

Please sign in to comment.