Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #251 #252

Closed
wants to merge 2 commits into from
Closed

Fix for #251 #252

wants to merge 2 commits into from

Conversation

akania
Copy link
Contributor

@akania akania commented Oct 1, 2014

Fix for #251

  • on windows paths need to be normalized - gherkin lexer files were not found
  • disabled 'debug' mode of browserify - it was creating huge source map and size of bundled file was exceding > 2MB
  • added optional param to the bundle script:
    $ node scripts/release.js gherkinLang=XX
    i.e:
    $ node scripts/release.js gherkinLang=en
    By default it includes all languages

@akania akania mentioned this pull request Oct 1, 2014
Closed
@jbpros
Copy link
Member

jbpros commented Dec 18, 2014

This PR contains nothing but a file mode change on bin/cucumber.js. Am I missing something here?

@jbpros jbpros closed this Dec 18, 2014
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akania @jbpros