Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Don't throw immediately when a parse error is encountered by gherkin - instead ensure all the errors (as well as any valid sources) are emitted and do a normal cleanup and exit.
Avoided making this part of
parseGherkinMessageStream
because that's on the public API (for now) and I didn't want to make a breaking change to its signature unnecessarily.⚡️ What's your motivation?
Fixes #1404.
Previously we'd throw on the first parse error and formatters wouldn't have a chance to do anything with it before the process exited.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist: