Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add name to cjs package.json #87

Merged
merged 2 commits into from
Mar 14, 2022
Merged

fix: add name to cjs package.json #87

merged 2 commits into from
Mar 14, 2022

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Mar 14, 2022 •
edited
Loading

🤔 What's changed?

This package.json was confusing a tool I'm trying to use to generate API documentation in cucumber-js - just adding the name there seems to be enough.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@davidjgoss
fix: add name to cjs package.json
218cb68 
This `package.json` was confusing a tool I'm trying to use to generate API documentation in cucumber-js - just adding the name there seems to be enough.
olleolleolle
olleolleolle approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it does the trick.

@davidjgoss davidjgoss merged commit ccd721b into main Mar 14, 2022
@davidjgoss davidjgoss deleted the cjs-package-name branch March 14, 2022 16:49
@davidjgoss davidjgoss mentioned this pull request Apr 7, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

@aslakhellesoy aslakhellesoy Awaiting requested review from aslakhellesoy

@aurelien-reeves aurelien-reeves Awaiting requested review from aurelien-reeves

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidjgoss @olleolleolle