Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET implementation of Cucumber Expressions #45

Merged
merged 25 commits into from
Nov 18, 2021
Merged

.NET implementation of Cucumber Expressions #45

merged 25 commits into from
Nov 18, 2021

Conversation

gasparnagy
Copy link
Member

@gasparnagy gasparnagy commented Nov 12, 2021

Description

This is a port of the java implementaition to .NET / C# with the following differences:

  • The ParameterTypeRegistry is not implemented here, only defines the IParameterTypeRegistry and IParameterType interfaces
  • The matching logic is not implemented in the expression implementation (cucumber, regex). Currently this logic sits in SpecFlow and it is not that easy (or makes sense) to move it out.

Also added a test-dotnet GitHub action.

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@gasparnagy gasparnagy marked this pull request as ready for review November 12, 2021 15:07
@gasparnagy
Copy link
Member Author

I think the failing JavaScript tests are unrelated to this...

@aurelien-reeves
Copy link
Contributor

aurelien-reeves commented Nov 12, 2021

I think the failing JavaScript tests are unrelated to this...

I do not reproduce the error on main, but I can reproduce it on your branch. Could you merge origin main into your branch?

Edit: indeed, after merging main in dotnet, tests are passing. Do you want I push the merge?

Edit 2: nevermind, I've been able to add the "Update branch" button to PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants