Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCK: Reconcile rules #76

Merged
merged 5 commits into from
Oct 31, 2023
Merged

CCK: Reconcile rules #76

merged 5 commits into from
Oct 31, 2023

Conversation

luke-hill
Copy link
Contributor

@luke-hill luke-hill commented Oct 13, 2023

rules is now is consistent for ruby/js.

I also massively removed the contradictory steps. Now it's at least consistent.

⚡️ What's your motivation?

Goes towards completion of issue in tracker

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)
  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@luke-hill luke-hill requested a review from davidjgoss October 13, 2023 08:53
@luke-hill
Copy link
Contributor Author

@davidjgoss think my knowledge of the assert library might be a bit lacking here. This will probably need a fix. I couldn't find a beEmpty() function

devkit/samples/rules/rules.feature.ts Outdated Show resolved Hide resolved
devkit/samples/rules/rules.feature.ts Outdated Show resolved Hide resolved
devkit/samples/rules/rules.feature.ts Outdated Show resolved Hide resolved
devkit/samples/rules/rules.feature.ts Outdated Show resolved Hide resolved
@luke-hill luke-hill merged commit 0a1e887 into main Oct 31, 2023
@luke-hill luke-hill deleted the bugfix/reconcile_rules branch October 31, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants