Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scenario for attached document with filename #35

Merged
merged 4 commits into from
Jul 8, 2023

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Jul 3, 2023

🤔 What's changed?

Adds a scenario to the attachments feature that attaches a PDF with a fileName attribute.

⚡️ What's your motivation?

  • CCK coverage for attachments with filenames

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss merged commit a9f3785 into main Jul 8, 2023
@davidjgoss davidjgoss deleted the feat/filename-attachment branch July 8, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant