Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cucumberdocs modified as per suggestions #39

Closed
wants to merge 42 commits into from

Conversation

gmk1217
Copy link
Contributor

@gmk1217 gmk1217 commented Jul 13, 2016

As per Aslak suggestions, I modified the documents.

@aslakhellesoy
Copy link
Contributor

We can't use copyrighted images, ref c1a7379

@gmk1217
Copy link
Contributor Author

gmk1217 commented Jul 13, 2016

Cant we use PC below the image...or at the end of the page

@aslakhellesoy
Copy link
Contributor

Please don't group several document changes into the same PR. See 783928e and c4a842c.

Once you have created a pull request you can continue to push new commits to the pull request's branch whenever you're addressing feedback comments. Don't create a new PR to addres them.

In this case I suggest you start over with new branches and pull requests since it's a little messy now.

git checkout master
git checkout -b docs-selenium
git add [selenium related docs]
git commit
git push
[create a PR]

Repeat the process for the other (unrelated docs).

Whenever you need to fix comments from us, update your existing PR:

git checkout docs-selenium
git add [the files you changed]
git commit
git push

@gmk1217
Copy link
Contributor Author

gmk1217 commented Jul 13, 2016

My bad, i was following the wrong way.
Thnx, will follow these steps

@aslakhellesoy
Copy link
Contributor

Cant we use PC below the image...or at the end of the page

Sorry, what is "PC"?

All creations are copyright by default, even without an explicit © sign, unless it's made explicit in writing that copying is allowed. Copying by anyone else than the copyright holder is illegal. See http://www.templetons.com/brad/copymyths.html

We should avoid using 3rd party images unless they have an explicit license (like creative commons) that permits copying.

Even when it's allowed we should avoid it since we want to have a consistent look and feel for the docs.

@gmk1217
Copy link
Contributor Author

gmk1217 commented Jul 13, 2016

PC: picture courtesy

@aslakhellesoy
Copy link
Contributor

No, we'd still be infringing copyright (unless the pic has a license permitting copying).

@gmk1217
Copy link
Contributor Author

gmk1217 commented Jul 13, 2016

ok will delete those

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants