-
-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cucumberdocs modified as per suggestions #39
Conversation
Auto commit by GitBook Editor
Auto commit by GitBook Editor
Removed unnecessary hyphen and modified SUMMARY.md
We can't use copyrighted images, ref c1a7379 |
Modified watir webdriver and renamed file.
Cant we use PC below the image...or at the end of the page |
Please don't group several document changes into the same PR. See 783928e and c4a842c. Once you have created a pull request you can continue to push new commits to the pull request's branch whenever you're addressing feedback comments. Don't create a new PR to addres them. In this case I suggest you start over with new branches and pull requests since it's a little messy now.
Repeat the process for the other (unrelated docs). Whenever you need to fix comments from us, update your existing PR:
|
My bad, i was following the wrong way. |
Sorry, what is "PC"? All creations are copyright by default, even without an explicit © sign, unless it's made explicit in writing that copying is allowed. Copying by anyone else than the copyright holder is illegal. See http://www.templetons.com/brad/copymyths.html We should avoid using 3rd party images unless they have an explicit license (like creative commons) that permits copying. Even when it's allowed we should avoid it since we want to have a consistent look and feel for the docs. |
PC: picture courtesy |
No, we'd still be infringing copyright (unless the pic has a license permitting copying). |
ok will delete those |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
As per Aslak suggestions, I modified the documents.