gherkin: Extract from Monorepo #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidjgoss the build is failing on what I guess are CJS vs ESM module problems. I've got no idea how to fix those. Could you help out with that? |
71 tasks
|
I’ll take a look. |
The gherkin submodule has been extracted into its own repository at: https://github.com/cucumber/gherkin
mpkorstanje
force-pushed
the
extract-gherkin-from-monorepo-2
branch
from
696c250 to
f52c863
Compare
|
The error is because the To fix I think you need to restore that file and then run |
|
Cheers. Much appreciated! |
|
Okay, different failures now - I'll check this out this evening and have a play. |
|
Okay fixed the npm stuff, just need to update make and CI config accordingly, working on that now. |
davidjgoss
approved these changes
Nov 9, 2022
mpkorstanje
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The gherkin submodule has been extracted into its own repository at:
https://github.com/cucumber/gherkin