-
-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Json schema for message protocol #1414
Conversation
Not sure if it's relevant, but following libraries might be helpful for the Elixir code generation: |
Thanks @WannesFransen1994 we'll have a look at those. |
The removal of "sudo" before installing npm globally was the thing to fix the CI? 😨 This is a big PR to review. Here's a big list of question 😅
|
Primarily finding breaking changes in APIs and data structures and update changelogs
Merge to master and continue working on Cucumber PRs
I think we can merge now, unless there are objections.
I think we can work on those after this is merged.
And Perl. I think we should disable them all (they already are). Waiting for them will cause too much delay. They can catch up at their own pace. We should create an issue for all 3 of them. |
This is a Draft PR to replace protobuf with pure JSON and JSON Schema, addressing #1386.
TODO:
Status
alternate type from the enum in the schema. Same forContentEncoding
Later:
We can live with a combination of protobuf/json schema implementations for some time, as long as we keep them in sync. The gherkin acceptance tests will catch any inconsistencies.