Drop support for Ruby 2.5 #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvz
force-pushed
the
drop-support-for-ruby-2-5
branch
from
7b5ce29 to
f3539c4
Compare
mvz
force-pushed
the
drop-support-for-ruby-2-5
branch
from
f3539c4 to
e2dbead
Compare
|
I'm going to delay this until cucumber itself drops support for 2.5. |
mvz
force-pushed
the
drop-support-for-ruby-2-5
branch
from
e2dbead to
4bc7347
Compare
|
Cucumber 8 has dropped support for Ruby 2.5. I'm first going to release a version with cucumber 8 support. After that, I'm going to revisit this pull request. |
mvz
force-pushed
the
drop-support-for-ruby-2-5
branch
2 times, most recently
from
b58ed24 to
c4e472c
Compare
|
It seems there's a consistent test failure with Ruby 3.1 on Windows that is only now coming to light because this pull request adds Ruby 3.1 to the matrix on Windows. The failure messages point to ChildProcess, but that project is not up-to-date on test environments so it's hard to tell whether Aruba is doing something wrong that only comes to light in that combination, or there's a problem with the combination of ChildProcess, Ruby 3.1 and Windows. |
8 tasks
- Require Ruby 2.6 or higher in the gemspec - Update RuboCop configuration and fix new offenses - Update set of Rubies in CI
ChildProcess does not play nice with Ruby 3.1 build for Windows used in GitHub Actions. See enkessler/childprocess#182
mvz
force-pushed
the
drop-support-for-ruby-2-5
branch
from
c4e472c to
cb53cc8
Compare
|
I dropped 3.1 from the Windows build set for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Drop support for Ruby 2.5
Details
Motivation and Context
With the release of JRuby 9.3.0.0, we can drop compatibility with Ruby 2.5. MRI 2.5 has been unmaintained for a while now.
How Has This Been Tested?
CI
Types of changes
This is a potentially breaking change for versions of rubygems and bundler that do not take ruby version requirements into account. From the standpoint of semver, it is not a breaking API change so does not require a major version bump.
Checklist: