Simplify configuration specification #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most contracts have redundant type information. An option generally accepts the same types as it returns. If it doesn't that's probably a bug. Allow specifying just the type and build a contract based on that.
mvz
force-pushed
the
simplify-configuration
branch
from
b910814 to
53e08b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove redundant type specifications in configuration reader and
accessor specifications
Details
Adjust the configuration specification DSL so the type of the option
only needs to be specified once.
Motivation and Context
Cleans up the codebase and is one step toward removing the dependency on
the contracts gem (see #770).
How Has This Been Tested?
I ran the specs.
Types of changes