Make disabling Bundler more robust #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvz
force-pushed
the
issue-699-make-disable-bundler-robust
branch
2 times, most recently
from
e89da8b to
e22b539
Compare
mvz
force-pushed
the
issue-699-make-disable-bundler-robust
branch
2 times, most recently
from
32f7be9 to
8550c91
Compare
This ensures they will be satisfied by whatever versions are installed to satisfy Aruba's own (development) dependencies.
mvz
force-pushed
the
issue-699-make-disable-bundler-robust
branch
from
8550c91 to
81c8105
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use Bundler's tooling to break out of the main bundle
Details
The
@disable_bundlertag doesn't always work very well because it just guesses at what enironment variables to disable. UseBundler.with_unbundled_envinstead to find the exact set of environment variables to change.Motivation and Context
Inspired by #699. While getting
keep_upto build with GitHub Actions I found out that the simple method of unsetting the environment variables does not work in all cases. See mvz/keep_up#40.How Has This Been Tested?
I ran the updated feature file.
Types of changes