Gemfile/Gemspec Tidy (For Master) #631
Conversation
NB: Minimum gem requirement is technically 2.3.3 because of a core dependency
|
I'll make one of these for |
|
ping @mvz i've no idea if the CI here is stable or not? Could you please advise? Can this be merged? |
|
I think an adjustment to Travis' configuration is needed. Hold on. |
Our test dependencies are in the development group now. The only extra gem that will be installed is yard-junk, but that should be fine.
| spec.add_development_dependency 'pry-doc', '~> 1.0.0' | ||
| spec.add_development_dependency 'rake', '~> 12.3' | ||
| spec.add_development_dependency 'rspec', '~> 3.6' | ||
| spec.add_development_dependency 'rubocop', '~> 0.69' |
There was a problem hiding this comment.
This should be ~> 0.69.0 because the set of cops can change with each release.
There was a problem hiding this comment.
I agree with this, but I just copied the existing config, all this PR is aimed to be is a tidy up.
aruba.gemspec
Outdated
| spec.rubygems_version = '>= 1.6.1' | ||
| spec.required_ruby_version = '>= 2.3' | ||
| spec.required_ruby_version = '>= 2.3.3' |
There was a problem hiding this comment.
I'm not a fan of excluding micro versions in general. Can we avoid this? Which of our depedencies needs 2.3.3? Maybe we need to test on 2.3.0 in Travis as well?
There was a problem hiding this comment.
One of the documentation ones in the development dependencies, if we reduce it down we should be ok
|
The build should be green now. The signs are good 🙂. |
Summary
Tidy up Gemfile / Deps
Details
Migrate everything that could be out of gemfile conditionals into gemspec fixed values.
NB: I've also updated a few minor version restrictions. And the minimum ruby version although this was always 2.3.3 due to a dependency requirement.
Motivation and Context
Tidies things up.
How Has This Been Tested?
CI
Types of changes
Checklist: