Improve build set for still branch #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also drops the unused cucumber-pro token
By letting Travis CI handle Bundler, caching will be automated.
- Use latest point release for CRubies starting from 2.2 - Drop 20 and 21 modes for JRuby. These do not seem to do the right thing and instead just test on JRuby 9.2 - Add 1.8 more for JRuby 1.7 via JRUBY_OPTS variable This was based on rspec's Travis CI build matrix.
mvz
force-pushed
the
improve-build-set-still
branch
from
6b7f009 to
6aa6721
Compare
There are two reasons for this: - Coverage is inaccurate unless running in debug mode - Simplecov breaks on JRuby 1.7 in 1.8 mode
mvz
force-pushed
the
improve-build-set-still
branch
from
6aa6721 to
e4539cf
Compare
This will also load the old childprocess version on CRuby 1.8, but the main point here is to use it with JRuby with the --18 flag, since it's the JRuby-specific code in childprocess that has an incompatibility.
mvz
force-pushed
the
improve-build-set-still
branch
from
c0369e1 to
2156ace
Compare
Something seems broken on 9.2.7.0 which is not broken on 9.2.6.0.
|
I've pinned the JRuby 9.2 version at 9.2.6.0 due to jruby/jruby#5738. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Several improvements to how we build on Travis CI.
Details
Motivation and Context
Our builds are very slow. At least we should build what is relevant.
How Has This Been Tested?
Travis is working on it.