Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add require time to avoid test failure #575

Merged
merged 1 commit into from
Oct 13, 2018

Conversation

henrich
Copy link
Contributor

@henrich henrich commented Oct 13, 2018

Summary

fix below test error (on Debian unstable)

Details

│ Run tests for ruby2.5 from debian/ruby-tests.rake │

All examples were filtered out; ignoring {:focus=>true}
# ./spec/aruba/api_spec.rb:333:in `block (5 levels) in <top (required)>'

 NoMethodError:
   undefined method `parse' for Time:Class
 Shared Example Group: "an existing directory" called from ./spec/aruba/api_spec.rb:388
 # ./spec/aruba/api_spec.rb:386:in `block (7 levels) in <top (required)>'
 # ./spec/aruba/api_spec.rb:381:in `block (6 levels) in <top (required)>'
 # ./lib/aruba/rspec.rb:22:in `block (2 levels) in <top (required)>'

Motivation and Context

How Has This Been Tested?

create debian package

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (cleanup of codebase without changing any existing functionality)
  • Update documentation

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

fix below test error (on Debian unstable)

> │ Run tests for ruby2.5 from debian/ruby-tests.rake                            │
>
> All examples were filtered out; ignoring {:focus=>true}
>      # ./spec/aruba/api_spec.rb:333:in `block (5 levels) in <top (required)>'
>
>      NoMethodError:
>        undefined method `parse' for Time:Class
>      Shared Example Group: "an existing directory" called from ./spec/aruba/api_spec.rb:388
>      # ./spec/aruba/api_spec.rb:386:in `block (7 levels) in <top (required)>'
>      # ./spec/aruba/api_spec.rb:381:in `block (6 levels) in <top (required)>'
>      # ./lib/aruba/rspec.rb:22:in `block (2 levels) in <top (required)>'
Copy link
Member

@xtrasimplicity xtrasimplicity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (pending CI success)!

@xtrasimplicity
Copy link
Member

Might need to rerun the AppVeyor suite. (I can't do it from my phone.) :)

@xtrasimplicity xtrasimplicity merged commit dd1e2a0 into cucumber:master Oct 13, 2018
@aslakhellesoy
Copy link
Contributor

Hi @henrich,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@xtrasimplicity
Copy link
Member

The AppVeyor suite has been broken for a while, and doesn't appear to have been impacted by this change. Merged. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants