Allow text after Background: and Examples: #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mladedav thanks for contributing! I've pushed some changes, mainly to reflect |
FCM |
tyranron
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this crate allows only whitespace after
Background:, but any characters should be allowed.From Gherkin reference
Each line that isn’t a blank line has to start with a Gherkin keyword, followed by any text you like.I have also checked online the the official JS implementation and it allows the text after.VS code extension also puts there some text by default which is how I stumbled upon this.
I have also added the same for
Examples:, all other keywords seem to have names normally so those should be covered.One more commit I did was overriding the transitive dependency on this crate in the cucumber test so that it uses this version, not anything in crates.io. I also had to update the cucumber version because of the crate name change.