Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin image base to python3.11 #16

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

tsotnikov
Copy link
Contributor

python3.12 has been recently release, seems that is causing trouble:

Traceback (most recent call last):
  File "/app/entrypoint.py", line 5, in <module>
    from main import Context
  File "/app/main.py", line 2, in <module>
    from j2cli.context import read_context_data
  File "/usr/local/lib/python3.12/site-packages/j2cli/__init__.py", line 10, in <module>
    from j2cli.cli import main
  File "/usr/local/lib/python3.12/site-packages/j2cli/cli.py", line 8, in <module>
    import imp, inspect
ModuleNotFoundError: No module named 'imp'

@tsotnikov tsotnikov changed the title Pin to image base to python3.11 Pin image base to python3.11 Oct 3, 2023
@ajeffowens
Copy link

This issue is causing failures for us, so I went ahead and created a forked version with the fix mentioned in this PR here in case anyone else needs it while we wait for a fix here. https://github.com/ajeffowens/jinja2-action

      uses: ajeffowens/[email protected]

@andre-lx
Copy link

andre-lx commented Oct 6, 2023

This issue is causing failures for us, so I went ahead and created a forked version with the fix mentioned in this PR here in case anyone else needs it while we wait for a fix here. ajeffowens/jinja2-action

      uses: ajeffowens/[email protected]

You could use the forked used to create this PR with:

Telefonica/[email protected]

@tsotnikov tsotnikov closed this Oct 9, 2023
@tsotnikov tsotnikov reopened this Oct 9, 2023
@2357gi
Copy link

2357gi commented Oct 10, 2023

@ajeffowens
Thank you for creating the forked version, it has been very helpful.
I would like to add a point. It is recommended to register the commit hash instead of the tag, as shown below:

        uses: ajeffowens/jinja2-action@90dab3da2215932ea86d2875224f06bbd6798617 # v2.0.0

@nyurik nyurik mentioned this pull request Oct 30, 2023
@cuchi cuchi merged commit 6d31ec7 into cuchi:master Nov 9, 2023
@cuchi
Copy link
Owner

cuchi commented Nov 9, 2023

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants