Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new version of poetry breaks workflow #22

Closed
dmytrolevin-fn opened this issue Jan 6, 2025 · 14 comments
Closed

new version of poetry breaks workflow #22

dmytrolevin-fn opened this issue Jan 6, 2025 · 14 comments

Comments

@dmytrolevin-fn
Copy link

The command '/bin/sh -c pip install poetry && poetry config virtualenvs.create false && poetry install' returned a non-zero code: 1

@shadowzen1978
Copy link

shadowzen1978 commented Jan 6, 2025

I came here to mention the same thing. The version of Poetry released yesterday is major version 2.0.0 which, of course, has a lot of breaking changes. It would be a good idea to pin the version used here in the Dockerfile to the last major 1.x.x version at least until the Poetry team can sort some of the bugs out or this repo can verify compatibility with 2.x.x of Poetry.

@dmytrolevin-fn
Copy link
Author

dmytrolevin-fn commented Jan 6, 2025

Moreover, I think everyone will agree that fixing the versions of all dependencies is the best practice to avoid such issues...
Fix of this looks simple
I see PR
#21
@cuchi was the last contributor who made the changes

@rondefreitas
Copy link

rondefreitas commented Jan 7, 2025

If the CD workflow had published a static docker image to dockerhub, and used that for the action instead of rebuilding the container each time, that would be an even better fix

@simioluwatomi
Copy link

I've been going crazy on this over 24 hours now. Good to know I'm not the only one experiencing this...

@dmytrolevin-fn
Copy link
Author

If the CD workflow had published a static docker image to dockerhub, and used that for the action instead of rebuilding the container each time, that would be an even better fix

@rondefreitas static Docker doesn't look as solution because if any dependency hasn't fixed version during docker build than it could be crashed in any time.
The best way for users of actions check the versions of all dependencies if it possible

@rondefreitas
Copy link

For anyone who needs this in the short term, I've published a fork of this on marketplace...

Use the action rondefreitas/[email protected]
I will remove the forked version once this is updated officially, but I needed to get our workflows back up and running.

@phillipleblanc
Copy link

Please don't remove your fork after its updated here 🙏

@vinayprakash893
Copy link

When i run in my github action with the updated master code

getting the below error, is it poetry install --no-root , causing issue..?

docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: exec: "/app/entrypoint.py": permission denied: unknown.

@rondefreitas
Copy link

@phillipleblanc I'll leave it in place for a while, but I didn't plan to keep the fork up to date or support using it that way long term... I just needed to fix broken workflows

@jcfr
Copy link

jcfr commented Jan 9, 2025

For anyone looking to reference a release associated with an organization rather than a user, we've published two new versions in a fork under the Slicer organization 🚀

Huge thanks to @OlivierCloudar and @lasith-kg for their respective contributions in PRs #21 and #19 🙏


v1.2.3

See https://github.com/Slicer/jinja2-action/releases/tag/v1.2.3

Includes [Backport PR-21] fix: solve poetry requirement for README.md


v1.2.4

See https://github.com/Slicer/jinja2-action/releases/tag/v1.2.4

Includes [Backport PR-19] (perf): Convert Python base image to python:3.11-alpine


For more details, check out the Slicer/jinja2-action repository.

Important

In the future, we may archive the Slicer/jinja2-action repository, but it will remain available and will not be deleted.

stefreak added a commit to garden-io/garden that referenced this issue Jan 9, 2025
This became necessary due to cuchi/jinja2-action#22 to keep updating our homebrew formula
stefreak added a commit to garden-io/garden that referenced this issue Jan 9, 2025
This became necessary due to cuchi/jinja2-action#22 to keep updating our homebrew formula
stefreak added a commit to garden-io/garden that referenced this issue Jan 9, 2025
This became necessary due to cuchi/jinja2-action#22 to keep updating our homebrew formula
stefreak added a commit to garden-io/garden that referenced this issue Jan 9, 2025
This became necessary due to cuchi/jinja2-action#22 to keep updating our homebrew formula
stefreak added a commit to garden-io/garden that referenced this issue Jan 9, 2025
This became necessary due to cuchi/jinja2-action#22 to keep updating our homebrew formula
github-merge-queue bot pushed a commit to garden-io/garden that referenced this issue Jan 9, 2025
This became necessary due to cuchi/jinja2-action#22 to keep updating our homebrew formula
github-merge-queue bot pushed a commit to garden-io/garden that referenced this issue Jan 9, 2025
This became necessary due to cuchi/jinja2-action#22 to keep updating our homebrew formula
@thelamer
Copy link

I am not clear what is going on here, the code is merged and a release has not been cut.
Is this waiting on alternative features?

@shadowzen1978
Copy link

@cuchi per prior comment, any chance we can get a release bump? It can be dangerous to put @main into an automated workflow instead of a proper version.

@cuchi
Copy link
Owner

cuchi commented Jan 17, 2025

Sorry for the delay, the latest release is available with the fixes.

Thank you all!

@cuchi cuchi closed this as completed Jan 17, 2025
@jcfr
Copy link

jcfr commented Jan 17, 2025

@cuchi Thanks for taking the time to work on this 🙏 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants