Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read the correct file from the database export. #184

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Read the correct file from the database export. #184

merged 1 commit into from
Dec 7, 2018

Conversation

timreyn
Copy link
Contributor

@timreyn timreyn commented Dec 7, 2018

No description provided.

@timreyn timreyn merged commit 568b4b4 into master Dec 7, 2018
@jfly
Copy link
Contributor

jfly commented Dec 30, 2018

Ah, sorry for the breakage! For the record, there's now an API endpoint for this you might find useful: https://www.worldcubeassociation.org/api/v0/export/public. This should be lighter weight than downloading the whole export just to check its timestamp.

@timreyn
Copy link
Contributor Author

timreyn commented Dec 30, 2018

Thanks! Two things:

  • IIRC, Lucas told me about this change in advance, and then I didn't fix it for a month after it broke. So this is entirely our fault, not yours :)
  • This job runs infrequently enough that this wouldn't save a significant amount of time or bandwidth. That said, I assume this is more stable long-term, so I filed Switch to WCA API for export timestamp #192 (though I'm not in a rush to address it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants