-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new event icons #133
base: main
Are you sure you want to change the base?
Add new event icons #133
Conversation
We could also add small circular holes in each 15 puzzle tile to make that icon stand out more |
@jfly thoughts on these? |
@jfly kind ping :) |
Yeah, certainly from my side at some point, I'm just juggling a lot. I do like all of these, but I think the Megaminx and Square-1 BLD icons would make more sense if the puzzle part wasfacing the other way (so that the blindfold isn't on the puzzle), what do you think? |
Here‘s a perspective of an unrelated third person and user of the other existing svg icons: I do like the proposed icons as they are right now. For me the event is easy to identify and with the current puzzle orientation, in my view more aesthetic. |
(Sorry for the silence here) I agree with @lgarron about the orientation of the megaminx and sq1 bld icons. Otherwise, this LGTM! |
I think this way makes more sense, because that's how the non-bld icons are positioned. The other way would make it seem like the icons are "out of frame". |
This PR adds the following event icons:
Magic One-Handed
2-man 2-7 Relay
15 puzzle
Megaminx Blindfolded
Square-1 Blindfolded
Siamese Cube
Previews:
This one is shown side-by-side with the 3bld icon, because there may be some concern of them being too similar at small scales. Another possible option is to show the entire Megaminx face except the three pieces shown here, but then it would have to be scaled down too much.