Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new event icons #133

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add new event icons #133

wants to merge 2 commits into from

Conversation

dmint789
Copy link
Contributor

@dmint789 dmint789 commented Sep 1, 2024

This PR adds the following event icons:

Magic One-Handed
2-man 2-7 Relay
15 puzzle
Megaminx Blindfolded
Square-1 Blindfolded
Siamese Cube

Previews:

magicoh

2-7 2p relay

15puzzle

This one is shown side-by-side with the 3bld icon, because there may be some concern of them being too similar at small scales. Another possible option is to show the entire Megaminx face except the three pieces shown here, but then it would have to be scaled down too much.

mega_bld + 333bf

Sq1bld

Siamese

@dmint789
Copy link
Contributor Author

dmint789 commented Sep 1, 2024

We could also add small circular holes in each 15 puzzle tile to make that icon stand out more

@dmint789
Copy link
Contributor Author

dmint789 commented Sep 3, 2024

@jfly thoughts on these?

@dmint789
Copy link
Contributor Author

dmint789 commented Oct 1, 2024

@jfly kind ping :)

@dmint789
Copy link
Contributor Author

@jfly

@dmint789
Copy link
Contributor Author

dmint789 commented Dec 7, 2024

@jfly @lgarron will there be any more activity in this repo? If not, I'll just make a fork of it and continue from there with new icons and with sorting out even IDs.

@lgarron
Copy link
Member

lgarron commented Dec 7, 2024

@jfly @lgarron will there be any more activity in this repo?

Yeah, certainly from my side at some point, I'm just juggling a lot.

I do like all of these, but I think the Megaminx and Square-1 BLD icons would make more sense if the puzzle part wasfacing the other way (so that the blindfold isn't on the puzzle), what do you think?

@AnnikaStein
Copy link

Here‘s a perspective of an unrelated third person and user of the other existing svg icons: I do like the proposed icons as they are right now. For me the event is easy to identify and with the current puzzle orientation, in my view more aesthetic.

@jfly
Copy link
Member

jfly commented Dec 18, 2024

(Sorry for the silence here) I agree with @lgarron about the orientation of the megaminx and sq1 bld icons. Otherwise, this LGTM!

@dmint789
Copy link
Contributor Author

(Sorry for the silence here) I agree with @lgarron about the orientation of the megaminx and sq1 bld icons. Otherwise, this LGTM!

I think this way makes more sense, because that's how the non-bld icons are positioned. The other way would make it seem like the icons are "out of frame".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants