Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, create-cubing-app errors out. Here is an example:
Line 69 of
bin/create-cubing-app.js
throws an error because of the leading slash onappTemplatePath
.For some reason on Windows, that makes Node
fs.cp
access a bad path with a doubleC:\
. On Linux the leading slash works fine.Solution is to use Node
url.fileURLToPath
to ensure the URL is a proper absolute path on different platforms. On Windows it removes the leading slash like so:'/C:/Users/ericx/Documents/dev/create-cubing-app/app-template'
'C:\\Users\\ericx\\Documents\\dev\\create-cubing-app\\app-template'