Update giraffeql boilerplate (backend)

cubing · May 19, 2021 · edb6ec3 · edb6ec3
1 parent f5b3ae8
commit edb6ec3
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 10 deletions.
diff --git a/backend/functions/src/index.ts b/backend/functions/src/index.ts
@@ -1,5 +1,7 @@
 import * as functions from "firebase-functions";
 import * as express from "express";
+import * as admin from "firebase-admin";
+admin.initializeApp();
 
 import { initializeGiraffeql } from "giraffeql";
 import "./schema";

diff --git a/backend/functions/src/schema/core/helpers/sql.ts b/backend/functions/src/schema/core/helpers/sql.ts
@@ -353,22 +353,34 @@ function applyWhere(
           break;
         case "in":
           if (Array.isArray(whereSubObject.value)) {
-            whereSubstatement += ` IN (${whereSubObject.value.map(() => "?")})`;
-            whereSubObject.value.forEach((ele) => {
-              bindings.push(ele);
-            });
+            // if array is empty, is equivalent of FALSE
+            if (whereSubObject.value.length < 1) {
+              whereSubstatement = "FALSE";
+            } else {
+              whereSubstatement += ` IN (${whereSubObject.value.map(
+                () => "?"
+              )})`;
+              whereSubObject.value.forEach((ele) => {
+                bindings.push(ele);
+              });
+            }
           } else {
             throw new Error("Must provide array for in/nin operators");
           }
           break;
         case "nin":
           if (Array.isArray(whereSubObject.value)) {
-            whereSubstatement += ` NOT IN (${whereSubObject.value.map(
-              () => "?"
-            )})`;
-            whereSubObject.value.forEach((ele) => {
-              bindings.push(ele);
-            });
+            // if array is empty, is equivalent of TRUE
+            if (whereSubObject.value.length < 1) {
+              whereSubstatement = "TRUE";
+            } else {
+              whereSubstatement += ` NOT IN (${whereSubObject.value.map(
+                () => "?"
+              )})`;
+              whereSubObject.value.forEach((ele) => {
+                bindings.push(ele);
+              });
+            }
           } else {
             throw new Error("Must provide array for in/nin operators");
           }