Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create /version command #250

Merged
merged 17 commits into from
Mar 16, 2023
Merged

Create /version command #250

merged 17 commits into from
Mar 16, 2023

Conversation

ccuser44
Copy link
Contributor

@ccuser44 ccuser44 commented Mar 1, 2023

No description provided.

@bearbin
Copy link
Member

bearbin commented Mar 5, 2023

Looks good :) Could you please add yourself to the CONTRIBUTORS file to indicate that you accept the licensing?

cmd_version.lua Outdated Show resolved Hide resolved
Info.lua Outdated Show resolved Hide resolved
Info.lua Outdated Show resolved Hide resolved
@ccuser44
Copy link
Contributor Author

ccuser44 commented Mar 6, 2023

Looks good :) Could you please add yourself to the CONTRIBUTORS file to indicate that you accept the licensing?

Done.

Copy link
Member

@madmaxoft madmaxoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put pretty much everything into an alpha-sorted order. That way things are easier to find later on.

CONTRIBUTORS Outdated Show resolved Hide resolved
Info.lua Outdated Show resolved Hide resolved
Info.lua Outdated Show resolved Hide resolved
Info.lua Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
cmd_version.lua Outdated Show resolved Hide resolved
@ccuser44 ccuser44 requested review from mathiascode and madmaxoft and removed request for mathiascode March 13, 2023 15:01
Copy link
Member

@madmaxoft madmaxoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks.

@mathiascode
Copy link
Member

CI is failing:

Scenario: fuzzing command "/about ".
Calling request "Command /about ".
lua: /home/runner/work/Core/Core/cmd_version.lua:3: bad argument #7 to 'format' (string expected, got function)
stack traceback:
	[C]: in function 'format'
	/home/runner/work/Core/Core/cmd_version.lua:3: in function 'Function'
	Simulator.lua:1391: in function 'processCallbackRequest'
	Simulator.lua:969: in function 'executePlayerCommand'
	Scenario.lua:172: in function 'fuzzSingleCommand'
	Scenario.lua:199: in function 'fuzzCommand'
	Scenario.lua:279: in function 'action'
	Scenario.lua:642: in function 'execute'
	Simulator.lua:1482: in function 'run'
	CuberitePluginChecker.lua:29: in main chunk
	[C]: ?

@mathiascode mathiascode merged commit bcba1c6 into cuberite:master Mar 16, 2023
@ccuser44 ccuser44 deleted the patch-1 branch March 18, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants