Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log webchat to server console. #166

Closed
wants to merge 1 commit into from
Closed

Log webchat to server console. #166

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 15, 2016

Feel free to let me know if I should have it log even more things. :)

Thanks.

@ghost
Copy link
Author

ghost commented Apr 15, 2016

Updated it to use LOGINFO to be in line with in-game chat logging.

@NiLSPACE
Copy link
Member

Looks alright to me.

@bearbin
Copy link
Member

bearbin commented Apr 15, 2016

Is there any restriction on what characters can be typed into the webchat? Some characters can mess up terminals, and blindly outputting them could cause corruption.

@NiLSPACE
Copy link
Member

I think we should fix that in Cuberite, not in the Core.

@ghost
Copy link
Author

ghost commented Apr 16, 2016

Good point, bearbin. I will look further into this and see if there's a
better way to sanitize any web user input before logging it.

As NiLSPACE said, maybe some checks can be put in place in Cuberite as
well.

Thanks.

On Fri, Apr 15, 2016 at 3:56 PM, NiLSPACE [email protected]
wrote:

I think we should fix that in Cuberite, not in the Core.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

@ghost ghost closed this Nov 25, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants