-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server-core): Support for scheduledRefreshTimeZones as function, passing securityContext #9002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
0a32483
to
e4bba5b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9002 +/- ##
=======================================
Coverage 82.85% 82.85%
=======================================
Files 221 221
Lines 78813 78813
=======================================
+ Hits 65299 65300 +1
+ Misses 13514 13513 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9a37858
to
a14b1bb
Compare
… passing securityContext
cover with tests
cf28dd2
to
8d8dc33
Compare
eae02a5
to
d2ca1d1
Compare
paveltiunov
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the ability to provide a scheduledRefreshTimeZones function as an alternative to a static timezone string array. This allows us to dynamically set the timezones used for the pre-aggregation refresh job. This is pretty neat for multi-tenant configurations allowing to specify different timezones for different tenants.
Closes #3509, #5015
Check List