fix: Install python3 executable for node-gyp #8998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcheshkov
force-pushed
the
container-image-yarn-missing-python
branch
from
bd817dd to
03f8b6c
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
mcheshkov
force-pushed
the
container-image-yarn-missing-python
branch
from
03f8b6c to
3028305
Compare
mcheshkov
force-pushed
the
container-image-yarn-missing-python
branch
from
3028305 to
58f4467
Compare
By default node-gyp looks only for `python` and `python3` executables, and python3.11 package installs only `python3.11` That leads to failure during installation optional dependency `java` from NPM even in `-jdk` image
mcheshkov
force-pushed
the
container-image-yarn-missing-python
branch
from
58f4467 to
056cd32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes Made (if issue reference is not provided)
By default node-gyp looks only for
pythonandpython3executables, and python3.11 package installs onlypython3.11That leads to failure during installation optional dependencyjavafrom NPM even in-jdkimageWithout
python3executablejavafails during installation, and because it is marked optional, installation is successful.But later, at runtime any JDBC driver would fail with
Cannot find module 'java', even in image with JDK installed.This PR installs
python3executable, as expected by node-gyp, but there are alternative aproaches:PYTHONenvironment variablenpm/yarn config set python, but that is not supported in NPM 9 and newer (Seenpm config set pythonno longer supported by npm as of npm v9.0.0 nodejs/node-gyp#2798)local.Dockerfileandtesting-drivers.Dockerfilewere not affected because they both hadpython3package installed before runningyarn install.