feat(cubesql): Penalize zero members in wrapper #8927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcheshkov
force-pushed
the
penalize-zero-members-in-wrapper
branch
from
eca2925
to
da51ec9
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
mcheshkov
force-pushed
the
penalize-zero-members-in-wrapper
branch
from
da51ec9
to
6376543
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8927 +/- ##
==========================================
+ Coverage 82.69% 82.72% +0.03%
==========================================
Files 221 221
Lines 78467 78624 +157
==========================================
+ Hits 64888 65044 +156
- Misses 13579 13580 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* Now column names, introudced by Datafusion, would get renamed, and that would avoid sending too long aliases to Cube for SQL generation, and later to data source * Single CubeScan can represent join of multiple TableScans, they can have different table aliases, and columns on top of CubeScan can have different qualifiers. But generated SQL can have only one table alias, so all column expressions on top needs to be remapped as well
mcheshkov
force-pushed
the
penalize-zero-members-in-wrapper
branch
from
6376543
to
cc05fdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
This would allow to extract fully assembled
CubeScanunder wrapper instead ofCubeScan(allMembers, ungrouped=true).ATM there are two related components in cost:
non_detected_cube_scansandcube_membersnon_detected_cube_scansallows to penalizeCubeScanwithout members specifically outside the wrapper. This is pretty hard penalty, queries like that are Not Good™cube_membersallows to prefer queries will less members, which seems fine. But on it's own it would prefer query with zero member, which is, actually, all the members.So, new cost component added:
zero_members_wrapper. It would stand right beforecube_members, and allow to penalize no-members representation beforecube_membersstarts impacting extraction.New
CubeScanextractions surfaced a couple of bugs related to aliasing in generated SQL, hence all the supporting stuff in this PR.