-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cubesql): Support to_timestamp(epoch) pg function, fix #8901 #8902
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
@droidraja Thanks for contributing! Could you please provide at least one test for it? Thanks! |
@paveltiunov, |
@paveltiunov have added the udf and testcases, please go ahead with the review. |
4c760e1
to
1740de2
Compare
@droidraja Could you also please update the docs here? https://cube.dev/docs/reference/sql-api#data-type-formatting-functions |
@igorlukanin This PR and the existing functionality supports evaluation of constant expression to cube time dimension filter and to_timestamp can't be applied to any columns. So it doesn't support both projection and post processing that is mentioned in the docs. @paveltiunov please correct my understanding if there are any holes. |
Check List
Issue Reference this PR resolves
#8901