-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAP HANA Driver implemented #5648
base: master
Are you sure you want to change the base?
Conversation
@ovr may I ask who will review my PR? |
Codecov ReportBase: 82.42% // Head: 40.81% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5648 +/- ##
===========================================
- Coverage 82.42% 40.81% -41.61%
===========================================
Files 139 150 +11
Lines 19621 19533 -88
Branches 0 5068 +5068
===========================================
- Hits 16172 7973 -8199
- Misses 3449 10736 +7287
- Partials 0 824 +824
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
and fix the data type mapping issue
Hey @zhjuncai ! Thanks for contributing to this one! Could you please also add at least a smoke E2E test? You can find an example here: https://github.com/cube-js/cube.js/blob/master/packages/cubejs-testing/test/smoke-materialize.test.ts. |
Thanks @paveltiunov I will try my best to add a smoke E2E test. |
CREATE TABLE test AS (SELECT * from TEST)
The HANAObjectStream doesn't work with cubestore to import csv to pre-aggregations schema Thus fallback to rows import which works well with pre-aggregations
It's not needed because the generated sql is not executed by HANA
Hello @paveltiunov I tried to add smoke test for hana driver, but it's not working as it still require test docker container for HANA. could you please review the driver first, once it's reviewed and merged. I will continue to smoke testing... |
@paveltiunov could you help to review? |
@zhjuncai Do you mean there's no docker image of SAP HANA available? |
@zhjuncai You might want to update https://www.npmjs.com/package/cubejs-hana-driver README as we published backlink here https://cube.dev/docs/config/databases#third-party-community-drivers. Please see https://github.com/cube-js/cube.js/blob/master/CONTRIBUTING.md#contributing-database-drivers for more info. |
There is no supported docker image for HANA for now, Hana-express docker image is deprecated, meanwhile Hana express also requires lots of memory to run. I don't want to run the deprecated image and drain your pipeline. > @zhjuncai Do you mean there's no docker image of SAP HANA available? |
I will update it soon. > @zhjuncai You might want to update https://www.npmjs.com/package/cubejs-hana-driver README as we published backlink here https://cube.dev/docs/config/databases#third-party-community-drivers. Please see https://github.com/cube-js/cube.js/blob/master/CONTRIBUTING.md#contributing-database-drivers for more info. |
I've updated the README, please start review process... |
Check List
Issue Reference this PR resolves
This is the initial driver implementation for SAP HANA, so no issue was resolved
Description of Changes Made (if issue reference is not provided)
SAP HANA is quite heavy database thus can't create a docker container to run test cases against it. I verified all the test on a remote HANA box. see the results
Latest Test results
