Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Bumping @hapi/joi to ^15.1.1 - Automatic Test Passing - Manual Not tested yet. #412

Merged
merged 2 commits into from
Feb 20, 2020
Merged

Conversation

andreasmarkussen
Copy link
Contributor

@andreasmarkussen andreasmarkussen commented Feb 19, 2020

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves
[bump version numbers - @hapi/[email protected], @hapi/[email protected] et. al. #411]
(#411)

Description of Changes Made (if issue reference is not provided)

  • Only one version updated so far but so many others are potential.

@andreasmarkussen
Copy link
Contributor Author

andreasmarkussen commented Feb 19, 2020

Many of the tests reported this actual error.

TypeError: Joi.validate is not a function
    at CubeValidator.validate (/home/circleci/repo/packages/cubejs-schema-compiler/compiler/CubeValidator.js:215:9)
    at cubeSymbols.cubeList.map (/home/circleci/repo/packages/cubejs-schema-compiler/compiler/CubeValidator.js:210:19)
    at Array.map (<anonymous>)

The joi.version changed in version 16.x so I will check version 15.1.1
https://hapi.dev/family/joi/changelog/

@andreasmarkussen andreasmarkussen changed the title [WIP] Bumping @hapi/joi to ^17.1.0 - NOT TESTED YET [WIP] Bumping @hapi/joi to ^15.1.1 - Automatic Test Passing - Manual Not tested yet. Feb 19, 2020
@paveltiunov
Copy link
Member

@andreasmarkussen Hey Andreas! Thanks for contributing this one! Bothered us for a while.

@paveltiunov paveltiunov merged commit cca69b6 into cube-js:master Feb 20, 2020
@paveltiunov
Copy link
Member

@andreasmarkussen Would love if you can bump all the places in the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants