Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: specify CUBEJS_DB_SSL_* environment variables can be contents of PEM file #2010

Merged
merged 1 commit into from
Feb 16, 2021
Merged

docs: specify CUBEJS_DB_SSL_* environment variables can be contents of PEM file #2010

merged 1 commit into from
Feb 16, 2021

Conversation

hassankhan
Copy link
Contributor

Description of Changes Made (if issue reference is not provided)

Specify CUBEJS_DB_SSL_* environment variables can be contents of PEM file

@hassankhan hassankhan added enhancement New feature proposal docs Issues that require a documentation improvement labels Feb 8, 2021
@hassankhan hassankhan self-assigned this Feb 8, 2021
@hassankhan hassankhan requested a review from a team as a code owner February 8, 2021 12:51
@hassankhan hassankhan force-pushed the hassankhan/docs/improve-database-ssl-section branch from c704d6b to 3ed9f10 Compare February 9, 2021 19:20
@keydunov
Copy link
Member

@ovr looks good to you?

@keydunov keydunov requested a review from ovr February 10, 2021 21:57
@ovr
Copy link
Member

ovr commented Feb 10, 2021 •
edited
Loading

@keydunov I don't think that it works, because dotenv package doesn't support multi-line env variables. I will prepare a fix for that (I will merge this one - motdotla/dotenv#486), because anyway we forked dotenv package to our organization - https://github.com/cube-js

@ovr
Copy link
Member

ovr commented Feb 11, 2021

@hassankhan I've prepared a PR with support for it. #2072 (not tested)

@ovr ovr mentioned this pull request Feb 11, 2021
Merged
@hassankhan hassankhan mentioned this pull request Feb 16, 2021
Closed
@hassankhan hassankhan force-pushed the hassankhan/docs/improve-database-ssl-section branch from 3ed9f10 to d4efeb2 Compare February 16, 2021 17:14
@hassankhan hassankhan force-pushed the hassankhan/docs/improve-database-ssl-section branch from d4efeb2 to 2498136 Compare February 16, 2021 17:19
@hassankhan hassankhan merged commit 2498136 into master Feb 16, 2021
@hassankhan hassankhan deleted the hassankhan/docs/improve-database-ssl-section branch February 16, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorlukanin igorlukanin igorlukanin approved these changes

@ovr ovr Awaiting requested review from ovr

Assignees

@hassankhan hassankhan

Labels
docs Issues that require a documentation improvement enhancement New feature proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hassankhan @keydunov @ovr @igorlukanin