Uses primitive accumulator for min and max, and backports CountGroupsAccumulator #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srh
force-pushed
the
groups-accumulator-primitive-other-types
branch
from
4075e10 to
7940cf9
Compare
srh
commented
Nov 27, 2024
| *x = (*x).max(y); | ||
| }, | ||
| ) | ||
| .with_starting_value(<$T as ArrowPrimitiveType>::Native::MIN), |
There was a problem hiding this comment.
With Cubestore running on the upstream DF branch we do see this issue with groups accumulators and different behavior with regular accumulators.
mysql> SELECT MAX(column3) FROM (VALUES (1, 2, NULL), (4, 5, '-Infinity'::double precision));
+--------------+
| max(column3) |
+--------------+
| -inf |
+--------------+
1 row in set (0.00 sec)
mysql> SELECT MAX(column3) FROM (VALUES (1, 2, NULL), (1, 5, '-Infinity'::double precision)) GROUP BY column1;
+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| max(column3) |
+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| -179769313486231570000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 |
+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.01 sec)
waralexrom
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Count GroupsAccumulator actually can't be made with PrimitiveGroupsAccumulator, and making an adapted version of PrimitiveGroupsAccumulator was sufficiently annoying, that a backported version of CountGroupsAccumulator as we have here works well enough.