Use basic GroupsAccumulator with GroupsAccumulatorFlatAdapter for sum and average accumulation #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waralexrom
approved these changes
Nov 5, 2024
…ng API This is based on upstream GroupsAccumulator and GroupsAccumulatorAdapter, but extends the API so that existing hash aggregation works with it. We basically don't really use the upstream interface (at this time). We still use basic Accumulator for types that do not implement GroupsAccumulator, and hash aggregation code handles this poorly.
srh
force-pushed
the
groups-accumulator
branch
from
18b3fae to
f86c41c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For small groups, this makes accumulation much faster, as, instead of creating and updating a bunch of
Box<dyn Accumulator>, we have aVec<Accumulator>. Some of this code is taken from upstream datafusion's GroupsAccumulator and GroupsAccumulatorAdapter.Some problems (presently) with this PR:
This also needs an update to arrow-rs: cube-js/arrow-rs#44