Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log and round function planning with second argument as int64 #173

Open
wants to merge 4 commits into
base: cubesql-3-04-2022
Choose a base branch
from

Conversation

droidraja
Copy link

@droidraja droidraja commented Nov 4, 2024

Closes cube-js/cube#8905

Add Int64 signatures for log and round function

@droidraja droidraja changed the title fix: round function planning for (float64,int64) fix: log and round function planning with second argument as int64 Nov 4, 2024
@paveltiunov
Copy link
Member

@droidraja Thanks for contributing! Could you please add test for that?

@droidraja
Copy link
Author

droidraja commented Nov 12, 2024

@paveltiunov Since this is a addition of a UDF function signature for which there is no implementation, I need to test this with a logical plan generation alone, should I do this in this repository or in the main cube repo ? , please suggest.

@droidraja
Copy link
Author

@paveltiunov Was able to find the right place in this repo itself to add appropriate testcases, please go ahead with the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants