feat: Subquery - ANY, ALL and IN support #142
Merged
+907
−291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovr
approved these changes
Feb 19, 2024
MazterQyou
approved these changes
Feb 19, 2024
| // This will be extended with `AnyAll` type. | ||
| /// ANY(...) / ALL(...) | ||
| AnyAll, | ||
| // [NOT] IN(...) is not defined as it is implicitly evaluated as ANY = (...) / ALL <> (...) // This will be extended with `AnyAll` type. |
There was a problem hiding this comment.
Legacy comment: // This will be extended with `AnyAll` type.
| @@ -341,8 +344,19 @@ impl Subquery { | |||
| pub fn transform_field(field: &Field, typ: SubqueryType) -> Field { | |||
| match typ { | |||
| SubqueryType::Scalar => field.clone(), | |||
| SubqueryType::Exists => Field::new(field.name(), DataType::Boolean, false), | |||
| // Field will be transformed for `AnyAll` as well | |||
| SubqueryType::Exists => Field::new(field.name(), DataType::Boolean, false), // Field will be transformed for `AnyAll` as well | |||
There was a problem hiding this comment.
Legacy comment: // Field will be transformed for `AnyAll` as well
| @@ -1039,18 +1039,140 @@ async fn test_binary_any() -> Result<()> { | |||
| // utf8 | |||
| test_expression!("'a' = ANY(['a', 'b'])", "true"); | |||
| test_expression!("'c' = ANY(['a', 'b'])", "false"); | |||
| //test_expression!("'c' = ANY(['a', NULL])", "NULL"); | |||
There was a problem hiding this comment.
Is this test commented out intentionally?
waralexrom
force-pushed
the
cubesql/subquery-exists
branch
from
215a977 to
fcacb68
Compare
waralexrom
force-pushed
the
cubesql/subquery-in-any-all
branch
from
545d684 to
2dbfc49
Compare
waralexrom
force-pushed
the
cubesql/subquery-in-any-all
branch
from
2dbfc49 to
74024b6
Compare
waralexrom
changed the base branch from
cubesql/subquery-exists
to
cubesql-3-04-2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?