Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master #2

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Master #2

wants to merge 7 commits into from

Conversation

theonlylooker
Copy link
Collaborator

No description provided.

Copy link
Member

@alrus2797 alrus2797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karldivad karldivad self-requested a review January 12, 2023 23:29
<div className="bg-blue-500 h-12 w-full pl-5 flex items-center rounded-t-lg">
<h1 className="text-lg font-semibold text-white">Primer Año</h1>
</div>
{/* progress bar */}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need of comments like this

import React from "react";
import { AiOutlineRight } from "react-icons/ai";

const Arrow = () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add type :React.FC

@@ -0,0 +1,9 @@
import React from "react";

const BlueDegrade = () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FC missing

@@ -0,0 +1,9 @@
import React from "react";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a way to avoid importing React on all files 🤔

noteData,
}) => {
const fileTypes = ["PDF"];
const { data, mutate } = useNotas();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spanish detected ⚰️

<div>
<Head>
<link
href="https://fonts.googleapis.com/css2?family=Quicksand:wght@300;400;500;600;700&display=swap"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to define it on tailwind for every page

modal: boolean;
settingModal: () => void;
}
export interface dragdropArea {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dragdropArea to DragDropArea plz 🙏

Also no need of doing export on every line, you could use at the end of the file:

export type {
  DragDropArea,
 NotesInfo,
 ....
 ...
}

@tailwind utilities;
@import url('https://fonts.googleapis.com/css2?family=Quicksand:wght@300;400;500;600;700&display=swap');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be like this 🤔 or as a static file on the server

html {
font-family: 'Quicksand';
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to use prettier to autoformat these files 👀

],
theme: {
extend: {},
extend: {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I also always prefer to use extend only 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants