-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master #2
base: main
Are you sure you want to change the base?
Master #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
<div className="bg-blue-500 h-12 w-full pl-5 flex items-center rounded-t-lg"> | ||
<h1 className="text-lg font-semibold text-white">Primer Año</h1> | ||
</div> | ||
{/* progress bar */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need of comments like this
import React from "react"; | ||
import { AiOutlineRight } from "react-icons/ai"; | ||
|
||
const Arrow = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add type :React.FC
@@ -0,0 +1,9 @@ | |||
import React from "react"; | |||
|
|||
const BlueDegrade = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FC missing
@@ -0,0 +1,9 @@ | |||
import React from "react"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a way to avoid importing React on all files 🤔
noteData, | ||
}) => { | ||
const fileTypes = ["PDF"]; | ||
const { data, mutate } = useNotas(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spanish detected ⚰️
<div> | ||
<Head> | ||
<link | ||
href="https://fonts.googleapis.com/css2?family=Quicksand:wght@300;400;500;600;700&display=swap" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to define it on tailwind for every page
modal: boolean; | ||
settingModal: () => void; | ||
} | ||
export interface dragdropArea { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dragdropArea to DragDropArea
plz 🙏
Also no need of doing export
on every line, you could use at the end of the file:
export type {
DragDropArea,
NotesInfo,
....
...
}
@tailwind utilities; | ||
@import url('https://fonts.googleapis.com/css2?family=Quicksand:wght@300;400;500;600;700&display=swap'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be like this 🤔 or as a static file on the server
html { | ||
font-family: 'Quicksand'; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to use prettier to autoformat these files 👀
], | ||
theme: { | ||
extend: {}, | ||
extend: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I also always prefer to use extend
only 👍
No description provided.