add support for nmea_time

ctuguinay · Dec 30, 2024 · 5c967cf · 5c967cf
1 parent 2959453
commit 5c967cf
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/echopype/convert/set_groups_base.py b/echopype/convert/set_groups_base.py
@@ -149,14 +149,14 @@ def set_nmea(self) -> xr.Dataset:
         ds = xr.Dataset(
             {
                 "NMEA_datagram": (
-                    ["time_nmea"],
+                    ["nmea_time"],
                     raw_nmea,
                     {"long_name": "NMEA datagram"},
                 )
             },
             coords={
-                "time_nmea": (
-                    ["time_nmea"],
+                "nmea_time": (
+                    ["nmea_time"],
                     time,
                     {
                         "axis": "T",

diff --git a/echopype/echodata/combine.py b/echopype/echodata/combine.py
@@ -18,7 +18,7 @@
 
 logger = _init_logger(__name__)
 
-POSSIBLE_TIME_DIMS = {"time1", "time2", "time3", "time4", "ping_time"}
+POSSIBLE_TIME_DIMS = {"time1", "time2", "time3", "time4", "nmea_time", "ping_time"}
 APPEND_DIMS = {"filenames"}.union(POSSIBLE_TIME_DIMS)
 DATE_CREATED_ATTR = "date_created"
 CONVERSION_TIME_ATTR = "conversion_time"

diff --git a/echopype/tests/echodata/test_echodata_combine.py b/echopype/tests/echodata/test_echodata_combine.py
@@ -157,7 +157,7 @@ def test_combine_echodata(raw_datasets):
 
     eds = [echopype.open_raw(file, sonar_model, xml_file) for file in files]
 
-    append_dims = {"filenames", "time1", "time2", "time3", "ping_time"}
+    append_dims = {"filenames", "time1", "time2", "time3", "nmea_time", "ping_time"}
 
     combined = echopype.combine_echodata(eds)
 

diff --git a/echopype/utils/coding.py b/echopype/utils/coding.py
@@ -27,6 +27,7 @@
 
 
 DEFAULT_ENCODINGS = {
+    "nmea_time": DEFAULT_TIME_ENCODING,
     "ping_time": DEFAULT_TIME_ENCODING,
     "ping_time_transmit": DEFAULT_TIME_ENCODING,
     "time1": DEFAULT_TIME_ENCODING,