Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reporting functionality #166

Merged
merged 10 commits into from
Oct 24, 2024
Merged

Conversation

ljwoodley
Copy link
Contributor

This PR:

  1. Creates render_report function to render rmd/qmd reports.
  2. Updates render_report.Rto use to outputs from render_report.
  3. Updates the example templates.
  4. Creates output folder in report and study_template/report.

Thoughts on creating a log folder inside report and study_template/report as log files will be created upon failure?

@ljwoodley ljwoodley requested a review from pbchase October 21, 2024 23:21
Copy link
Contributor

@pbchase pbchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Everything works and it looks clean. I only had two comments and they're not that important

report/render_report.R Outdated Show resolved Hide resolved
report/render_report.R Outdated Show resolved Hide resolved
@pbchase
Copy link
Contributor

pbchase commented Oct 22, 2024

Thoughts on creating a log folder inside report and study_template/report as log files will be created upon failure?

I wasn't sure what you meant by this, but I like that your new function captures the log output and returns it. It's nice design. The function is "full service"

@pbchase pbchase self-requested a review October 24, 2024 17:30
@pbchase pbchase merged commit 9c3221a into ctsit:develop Oct 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants