Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

date/rater fix #118

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

elijahrockers
Copy link

@elijahrockers elijahrockers commented Jan 27, 2021

What does this change do? Please be clear and concise.

Uses the form-specific dates and rater initials for UDS3 and FTLD, initial and followup visits.

Why was this change made? Including an issue number is sufficient. Otherwise, briefly explain the benefit of the change.

Implemented for Houston Methodist. Dates and raters should reflect the dates and raters on the source documents.

Verification

redcap2nacc -ivp -file redcap_file_with_varying_dates.csv > nacc_output.txt

Varying dates and raters should appear in the output text file.

Affirmations

All of these should have a check by them. Any exception requires an explanation.

  • I matched the style of the existing code.
  • I added and updated any relevant documentation (inline, README, CHANGELOG, and such).
  • I used Python's type hinting.
  • I ran the automated tests and ensured they ALL passed.
  • I ran the linter and ensured my changes have not introduced ANY warnings or errors.
  • I have made an effort to minimize code changes and have not included any cruft (preference files, *.pyc files, old comments, print-debugging, unused variables).
  • I have made an effort maintain a clear commit history (haven't merged other branches or rebased improperly).
  • I have written the code myself or have given credit where credit is due.

@elijahrockers
Copy link
Author

I realize now you have a filter for "fixing" the drug IDs, which I was not aware of. So you could ignore that.

@s-emerson s-emerson changed the base branch from master to develop February 8, 2021 21:21
…the UDS Z1X. NACC does not seem to like duplicate entries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants