Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Content-Disposition" header missing when downloading artifact from artifacts view #90

Closed
SvenEwald opened this issue May 22, 2015 · 4 comments
Assignees
Milestone

Comments

@SvenEwald
Copy link

Minor issue in the details page for artifacts:

  • Go to channel contents
  • Click on details for a jar
  • Click on download
  • Instead of downloading the jar, a download of "dump" is startet.

It works in the channel contents page, but not in the artifact details page.
PD 0.9.0, FF 38.0.1

@ctron ctron self-assigned this May 22, 2015
@ctron
Copy link
Owner

ctron commented May 22, 2015

Damn! Thanks for reporting!

@afischer211
Copy link

I can commit the bug. But the content of the downloaded "dump"-file is ok (only the bad name-suggestion).

@ctron
Copy link
Owner

ctron commented May 26, 2015

Ok, so I guess the artifact is downloaded without a proper Content-Disposition header in the HTTP response header.

@ctron ctron changed the title Download artifact from details view does not work "Content-Disposition" header missing when downloading artifact from artifacts view May 27, 2015
@ctron
Copy link
Owner

ctron commented May 27, 2015

The link labeled "download" actually pointed to the "view" action of the artifact. So clicking on a binary artifact, which the browser does not understand, or the mime aspect is missing, then the browser suggests to save the artifact as dump.

The download link was redirected to the "get" operation, which provides the Content-Disposition header with the correct filename. Also the "view" button was added. So both, channel and artifact view, now provide the same operations.

@ctron ctron added this to the v0.9.1 milestone May 27, 2015
@ctron ctron closed this as completed May 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants