Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.0 #20

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Release 2.0 #20

merged 1 commit into from
Dec 12, 2022

Conversation

l0rn
Copy link

@l0rn l0rn commented Dec 12, 2022

This commit introduces potentially breaking changes as it adjust this plugin to be compatible with certbot >=2.0 and implements best practices from certbot2.

  • Remove custom hetzner client in favor for lexicon implementation
  • Version of this plugin 2.0 is only compatible with certbot>=2.0
  • General simplification

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #20 (2300d53) into main (18a30b0) will decrease coverage by 1.88%.
The diff coverage is 85.71%.

❗ Current head 2300d53 differs from pull request most recent head a9beb49. Consider uploading reports for the commit a9beb49 to get more accurate results

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   91.47%   89.58%   -1.89%     
==========================================
  Files           3        2       -1     
  Lines         129       48      -81     
==========================================
- Hits          118       43      -75     
+ Misses         11        5       -6     
Flag Coverage Δ
unittests 89.58% <85.71%> (-1.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
certbot_dns_hetzner/dns_hetzner.py 86.48% <82.60%> (-3.26%) ⬇️
certbot_dns_hetzner/fakes.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@l0rn l0rn force-pushed the 2.0-dev branch 3 times, most recently from 328497d to 2300d53 Compare December 12, 2022 12:58
This commit introduces potentially breaking changes as it adjust this plugin to be compatible with certbot >=2.0
and implements best practices from certbot2.

* Remove custom hetzner client in favor for lexicon implementation
* Version of this plugin 2.0 is only compatible with certbot>=2.0
* General simplification
@l0rn l0rn merged commit 3504a7d into main Dec 12, 2022
@l0rn l0rn deleted the 2.0-dev branch December 12, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant