-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added confluence template api #320
Open
Fank
wants to merge
5
commits into
main
Choose a base branch
from
feature/confluence-templates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Took 2 hours 39 minutes
Took 4 minutes
ctreminiom
force-pushed
the
feature/confluence-templates
branch
from
September 30, 2024 05:51
ab8538c
to
fe4589b
Compare
Hi @Fank, sorry for the delayed response. I just tested and it works, thanks!!. I created the official documentation: https://docs.go-atlassian.io/confluence-cloud/template. Can you please link the official documentation on the server/implementation method comments?. |
Will add it |
Took 17 minutes
Took 2 minutes
@ctreminiom sorry for delay, updated URLs and updated code to latest master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for template operations in the Confluence API client. The main changes include the addition of a new
TemplateService
with methods to create, update, and retrieve templates, as well as the necessary data models and tests.New Template Service:
TemplateService
to theClient
struct inconfluence/api_client_impl.go
to support template operations. ([1]
,[2]
)TemplateService
with methodsCreate
,Update
, andGet
inconfluence/internal/template_impl.go
. (confluence/internal/template_impl.goR1-R110
)Data Models:
pkg/infra/models/confluence_template.go
, includingCreateTemplateScheme
,UpdateTemplateScheme
, andContentTemplateScheme
. (pkg/infra/models/confluence_template.goR1-R109
)Interface:
TemplateConnector
interface inservice/confluence/template.go
to abstract the template operations. (service/confluence/template.goR1-R30
)Tests:
TemplateService
methods inconfluence/internal/template_impl_test.go
to ensure proper functionality. (confluence/internal/template_impl_test.goR1-R380
)This is a partial implementation, I only implemented the function I currently use.