Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Added the Page.Gets() method on the Confluence V2 module #235

Merged
merged 3 commits into from
Aug 14, 2023

Conversation

ctreminiom
Copy link
Owner

  1. Created a method called Gets() under the PageConnector interface

  2. Deprecated the Bulk() method because the Gets() method enables the possibility to set filter criteria.

  3. Removed the BulkFiltered() method

  4. Added the Unit Test Cases with a 95% of coverage.

1. Created a method called Gets() under the PageConnector interface

2. Deprecated the Bulk() method because the Gets() method enables the possibility to set filter criteria.

3. Removed the BulkFiltered() method

4. Added the Unit Test Cases with a 95% of coverage.
@ctreminiom ctreminiom added enhancement New feature or request Confluence labels Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #235 (9fa560e) into main (1ea650d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 9fa560e differs from pull request most recent head b5a344d. Consider uploading reports for the commit b5a344d to get more accurate results

@@           Coverage Diff           @@
##             main     #235   +/-   ##
=======================================
  Coverage   89.23%   89.24%           
=======================================
  Files         146      146           
  Lines       11455    11465   +10     
=======================================
+ Hits        10222    10232   +10     
  Misses        624      624           
  Partials      609      609           
Files Changed Coverage Δ
confluence/internal/page_impl.go 91.17% <100.00%> (+0.70%) ⬆️

@ctreminiom ctreminiom merged commit 2b9d1b5 into main Aug 14, 2023
42 checks passed
@Fank Fank deleted the feature/confluence-page-gets-v2 branch June 27, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confluence enhancement New feature or request
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

1 participant