Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/notification schemes #190

Merged
merged 3 commits into from
Apr 28, 2023
Merged

Feature/notification schemes #190

merged 3 commits into from
Apr 28, 2023

Conversation

ctreminiom
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #190 (c3fe434) into main (e6e3e5d) will increase coverage by 0.00%.
The diff coverage is 85.61%.

@@           Coverage Diff            @@
##             main     #190    +/-   ##
========================================
  Coverage   85.29%   85.29%            
========================================
  Files         130      131     +1     
  Lines       11171    11310   +139     
========================================
+ Hits         9528     9647   +119     
- Misses        919      929    +10     
- Partials      724      734    +10     
Impacted Files Coverage Δ
jira/v2/api_client_impl.go 57.93% <50.00%> (-0.12%) ⬇️
jira/v3/api_client_impl.go 57.93% <50.00%> (-0.12%) ⬇️
jira/internal/notification_scheme_impl.go 87.78% <87.78%> (ø)

1. The notification schemes can be linked with a project, but there are no exclusivity related to the project.
2. Hence, the service was moved under the root library and not under the project service.
@ctreminiom ctreminiom merged commit 511fc99 into main Apr 28, 2023
@ctreminiom ctreminiom deleted the feature/notification-schemes branch May 15, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

1 participant