Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the expand option to the internalSearch implementation for content #182

Merged
merged 1 commit into from
Apr 1, 2023

Conversation

mpecan
Copy link
Contributor

@mpecan mpecan commented Mar 31, 2023

Background

The internal content search implementation currently does not propagate the "expand" option to the underlying query. This does not allow the user to pass that parameter in.

I adjusted the appropriate tests.

@ctreminiom ctreminiom added bug Something isn't working Confluence labels Apr 1, 2023
@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Merging #182 (1c3a198) into main (97f115d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #182   +/-   ##
=======================================
  Coverage   85.79%   85.80%           
=======================================
  Files         125      125           
  Lines       10674    10677    +3     
=======================================
+ Hits         9158     9161    +3     
  Misses        857      857           
  Partials      659      659           
Impacted Files Coverage Δ
confluence/internal/search_impl.go 93.65% <100.00%> (+0.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ctreminiom
Copy link
Owner

Hi @mpecan,

I just wanted to give you a quick shoutout and say thanks for your contribution. You're right, the expand tag was not propagating the values on the endpoint.

Merging the changes...

@ctreminiom ctreminiom merged commit a2e2612 into ctreminiom:main Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Confluence
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

2 participants