Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users are unable to use v2.0.0+ versions of the library #330

Closed
5 tasks done
skovtunenko opened this issue Oct 19, 2024 · 2 comments
Closed
5 tasks done

Users are unable to use v2.0.0+ versions of the library #330

skovtunenko opened this issue Oct 19, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@skovtunenko
Copy link

go-atlassian version
v2.0.0 - v2.1.1

go-atlassian component

  • Jira Software Cloud
  • Jira Agile Cloud
  • Jira Service Management Cloud
  • Confluence Cloud
  • Atlassian Admin Cloud

Describe the bug 🐛

Users are unable to use v2.0.0+ versions of the library.

The tagged version of the library v2.0.0 - v2.1.1 does not match the go module definition.

The Go module file should have ..../v2 at the end of the module name.

Quote from the documentation (https://go.dev/ref/mod#major-version-suffixes):

Starting with major version 2, module paths must have a major version suffix like /v2 that matches the major version. For example, if a module has the path example.com/mod at v1.0.0, it must have the path example.com/mod/v2 at version v2.0.0.

To Reproduce 🚧

$ go get github.com/ctreminiom/go-atlassian
go: downloading github.com/ctreminiom/go-atlassian v1.6.1
go: added github.com/ctreminiom/go-atlassian v1.6.1

$ go get github.com/ctreminiom/[email protected]
go: github.com/ctreminiom/[email protected]: invalid version: module contains a go.mod file, so module path must match major version ("github.com/ctreminiom/go-atlassian/v2")

Expected behavior

A version v2.1.1 should be downloaded

Screenshots 📄

None.

Additional context

None.

@skovtunenko skovtunenko added the bug Something isn't working label Oct 19, 2024
ctreminiom added a commit that referenced this issue Oct 20, 2024
ctreminiom added a commit that referenced this issue Oct 20, 2024
ctreminiom added a commit that referenced this issue Oct 20, 2024
ctreminiom added a commit that referenced this issue Oct 20, 2024
ctreminiom added a commit that referenced this issue Oct 20, 2024
@ctreminiom
Copy link
Owner

Hi @skovtunenko, thanks for the report, my apologies.

can you please try it again?, it should download the version v2.1.2

@skovtunenko
Copy link
Author

@ctreminiom, now it is working. I was able to download the latest lib.

I guess the Github pages need to be updated as well: https://docs.go-atlassian.io/#installation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants