Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null handling to json serialization #54

Merged
merged 1 commit into from
May 16, 2024

Conversation

manzanotti
Copy link

The move to System.Text.Json from Json.Net for v4 had the unfortunate side-effect of removing null handling, causing issue #21 to re-appear.

This PR adds it back in.

@ctolkien
Copy link
Owner

ctolkien commented May 7, 2024

Thanks for this.

This is probably something we should add unit tests for at some point.

@ctolkien
Copy link
Owner

ctolkien commented May 7, 2024

Gah, PAT has expired. I'll fix this up shortly.

@ctolkien ctolkien merged commit 6c63607 into ctolkien:main May 16, 2024
1 of 2 checks passed
@manzanotti manzanotti deleted the FixResizeCalls branch May 16, 2024 07:49
@ctolkien
Copy link
Owner

@manzanotti this is now available for testing on the GitHub Nuget repo here:
https://github.com/ctolkien/TinyPNG/pkgs/nuget/TinyPNG

I'll get another prerelease for Nuget.org out soon.

@manzanotti
Copy link
Author

@manzanotti this is now available for testing on the GitHub Nuget repo here: https://github.com/ctolkien/TinyPNG/pkgs/nuget/TinyPNG

I'll get another prerelease for Nuget.org out soon.

Great, thanks. I might be able to test it this afternoon, otherwise it will be tomorrow, just working on something else at the moment.

@ctolkien
Copy link
Owner

@manzanotti

Great, thanks. I might be able to test it this afternoon, otherwise it will be tomorrow, just working on something else at the moment.

No worries. Build has gone for NuGet prerelease:
https://www.nuget.org/packages/TinyPNG/4.0.0-prerelease.68

Should show up soon ™️ once the NuGet indexing is done.

@manzanotti
Copy link
Author

@ctolkien Pre-release works fine, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants